| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |
| Date: | 2024-12-12 04:24:42 |
| Message-ID: | CAHut+PvYsVhF5k-mYHVEFdpijdgkYRtoeWVxdspxio0ePRpkug@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 12, 2024 at 2:53 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
...
> > So, AFAICT I can workaround the perltidy wrapping just by putting all
> > the noarg options at the bottom of the command, then all the
> > option/optarg pairs (ie 2s) will stay together. I can post another
> > patch to do it this way unless you think it is too hacky.
>
> This trick works for me if that makes the long list of option easier
> to read. With two elements of the array perl line, I would just put
> some --dry-run or --verbose at the end of their respective arrays.
> --
> Michael
Hi Michael.
Yes, that is the workaround that I was proposing.
PSA v2-0001. This time it can survive pgperltidy unchanged.
In passing I also removed the duplicated '--verbose' and changed the
'Pub2' case mentioned in the original post.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Modify-wrapping-to-make-command-options-easier-to.patch | application/octet-stream | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-12-12 04:35:56 | Re: Add Postgres module info |
| Previous Message | vignesh C | 2024-12-12 04:12:35 | Re: Introduce XID age and inactive timeout based replication slot invalidation |