| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Outdated comment on scram_build_secret |
| Date: | 2024-12-10 00:58:28 |
| Message-ID: | Z1eSNOhzV3yLzXKS@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 09, 2024 at 08:39:03PM -0300, Matheus Alcantara wrote:
> Commit b577743000 introduced the assert and remove the if condition. All
> usages of this function is using an iteration > 0, so I think that is just a
> matter of updating the documentation? If that's the case the attached patch
> does that.
Ah, good catch.
> - * If iterations is 0, default number of iterations is used. The result is
> - * palloc'd or malloc'd, so caller is responsible for freeing it.
> + * The result is palloc'd or malloc'd, so caller is responsible for freeing it.
Removing the comment sounds like the right thing to do here. I'll go
do that in a bit down to v16.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-12-10 01:14:17 | Fix some comments for GUC hooks of timezone_abbreviations |
| Previous Message | Michael Paquier | 2024-12-10 00:54:36 | Re: shared-memory based stats collector - v70 |