Re: shared-memory based stats collector - v70

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: shared-memory based stats collector - v70
Date: 2024-12-10 00:54:36
Message-ID: Z1eRTELjXqieX0mI@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 09, 2024 at 08:03:54AM +0000, Bertrand Drouvot wrote:
> Right. OTOH I think that could help the tap test added in da99fedf8c to not
> rely on assert enabled build (the tap test could "simply" check for the
> WARNING in the logfile instead).

That's true. Still, the coverage that we have is also enough for
assert builds, which is what the test is going to run with most of the
time anyway.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-12-10 00:58:28 Re: Outdated comment on scram_build_secret
Previous Message Andres Freund 2024-12-10 00:31:18 Re: FileFallocate misbehaving on XFS