| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Date: | 2024-12-05 04:52:19 |
| Message-ID: | Z1Exg7mY0koNM53v@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 05, 2024 at 04:31:56AM +0000, Zhijie Hou (Fujitsu) wrote:
> I realized that this patch cannot be backpatched because it introduces a new
> field into the public PGOutputData structure. Therefore, I think we may need to
> use Alvaro's version [1] for the back branches.
>
> [1] https://www.postgresql.org/message-id/202411300828.hwe55pzx5a4x%40alvherre.pgsql
Thanks for the patch.
For HEAD it should be as good as it can be as it avoids the problem of
CacheMemoryContext bloating for your case and my case. Alvaro's patch
would not take care of your case, unfortunately, but I'm less worried
about this case in the back branches and we don't track the parent
context where StartupDecodingContext() has begun its work when
building PGOutputData. Thoughts?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-12-05 05:32:20 | Re: NOT ENFORCED constraint feature |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-12-05 04:31:56 | RE: Memory leak in WAL sender with pgoutput (v10~) |