| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Memory leak in WAL sender with pgoutput (v10~) |
| Date: | 2024-12-06 08:23:13 |
| Message-ID: | OS0PR01MB571640AB8FDA354CAB89066694312@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, December 5, 2024 12:52 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
Hi,
>
> On Thu, Dec 05, 2024 at 04:31:56AM +0000, Zhijie Hou (Fujitsu) wrote:
> > I realized that this patch cannot be backpatched because it introduces
> > a new field into the public PGOutputData structure. Therefore, I think
> > we may need to use Alvaro's version [1] for the back branches.
> >
>
> Thanks for the patch.
>
> For HEAD it should be as good as it can be as it avoids the problem of
> CacheMemoryContext bloating for your case and my case. Alvaro's patch
> would not take care of your case, unfortunately, but I'm less worried about this
> case in the back branches and we don't track the parent context where
> StartupDecodingContext() has begun its work when building PGOutputData.
> Thoughts?
I am fine with the plan. Thanks.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-12-06 08:26:49 | Re: generic plans and "initial" pruning |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-12-06 08:23:00 | RE: Memory leak in WAL sender with pgoutput (v10~) |