Re: confusing / inefficient "need_transcoding" handling in copy

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sutou Kouhei <kou(at)clear-code(dot)com>
Cc: andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org, ishii(at)sraoss(dot)co(dot)jp
Subject: Re: confusing / inefficient "need_transcoding" handling in copy
Date: 2024-12-14 07:46:57
Message-ID: Z1038XR8LgsnntHh@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 13, 2024 at 12:27:37PM +0900, Sutou Kouhei wrote:
> Oh, sorry... I attached wrong patch...
> I attach the v4 patch that includes this case.

Sounds fair to me as a beginning for the code paths setting
need_transcoding.

Note that using "test" as table name for the tests is not a good idea,
as this could very likely conflict with some concurrent activity. I
would also add two RESET queries to remove the dependency to
client_encoding once the test has no need to rely on it. No need to
send a new patch for all that, just noticing in passing.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-12-14 08:29:12 Re: FileFallocate misbehaving on XFS
Previous Message John Naylor 2024-12-14 05:08:57 Re: Proposal for Updating CRC32C with AVX-512 Algorithm.