Re: pg_combinebackup PITR comparison test fix

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_combinebackup PITR comparison test fix
Date: 2024-12-16 05:14:55
Message-ID: Z1-3T3jo2PvYEGEl@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 15, 2024 at 10:34:07AM +0900, Michael Paquier wrote:
> Indeed, good catch. I'll take care of it.

+ sub {
+ s{create tablespace .* location '.*/tspitr\K[12]}{N}i for @_;
+ return $_[0] ne $_[1];
+ });

The CI is complaining on this one because the custom comparison
function is not able to digest WIN32 paths, leading to failures in the
dump comparison like that:
-CREATE TABLESPACE ts1 OWNER "SYSTEM" LOCATION
E'C:\\Windows\\TEMP\\tJ4qTmrkZv\\tspitr1';
+CREATE TABLESPACE ts1 OWNER "SYSTEM" LOCATION
E'C:\\Windows\\TEMP\\tJ4qTmrkZv\\tspitr2';

So there is an issue with the slash character after the location and
the single space before the quote. We could use something like this
one which would handle the paths sanely:
s{create tablespace .* location .*'.*tspitr\K[12]}{N}i for @_;

Perhaps you are able to come with a more elegant string?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-12-16 05:23:14 Re: Regression tests fail on OpenBSD due to low semmns value
Previous Message Andrei Lepikhov 2024-12-16 05:02:14 Re: Add Postgres module info