Re: query_id: jumble names of temp tables for better pg_stat_statement UX

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Date: 2025-03-26 06:24:49
Message-ID: Z-OdsRQUmwtSa_4l@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Tue, Mar 25, 2025 at 07:56:29PM -0500, Sami Imseih wrote:
> FWIW, the pg_stat_statements docs in a few places refer to
> queries that may look different but have the same meaning
> as “semantically equivalent”, this is why I used the same
> terminology here. But, I have no issue with the simplified
> rewrite either.
>
> The patch LGTM as well.

If any adjustments are required, it would be always possible to do
these later. Anyway, workloads with a lot of temporary tables are
going to benefit from this change, so let's see how it goes.

Applied, after eyeing much more the PGSS dumps from installcheck
before and after the patch, to make sure that I'm not missing
something..
--
Michael

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Alexander Farber 2025-03-26 10:31:39 Re: How to pass a list of locations (longitude, latitude) to a PostgreSQL/PostGIS stored function?
Previous Message Tony Shelver 2025-03-26 05:33:26 Re: How to pass a list of locations (longitude, latitude) to a PostgreSQL/PostGIS stored function?

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2025-03-26 06:30:54 Re: a pool for parallel worker
Previous Message David G. Johnston 2025-03-26 06:17:39 Doc: Add Table of Contents to psql Reference Page