Re: query_id: jumble names of temp tables for better pg_stat_statement UX

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Lukas Fittl <lukas(at)fittl(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Date: 2025-03-25 07:02:08
Message-ID: Z-JU8EmGdlnNEGot@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Mon, Mar 24, 2025 at 11:09:06PM -0700, Lukas Fittl wrote:
> For what its worth, +1 on the current proposal in this thread (and doing it
> without a GUC), i.e. merging a query that references the same table alias,
> ignoring different schemas.

Thanks for the feedback. I have looked again at the first patch to
add custom_query_jumble as a node field attribute, adjusted some
comments, and applied it as 5ac462e2b7ac.

Attached is the second one, with more tests coverage with attribute
aliases (these being ignored exists in stable branches, but why not
while on it) and table aliases, and the fixes for the issues pointed
out by Christoph. I'll double-check all that again tomorrow. Please
find an updated version attached for now.
--
Michael

Attachment Content-Type Size
v5-0001-Add-custom-query-jumble-function-for-RangeTblEntr.patch text/x-diff 11.0 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Ron Johnson 2025-03-25 08:53:51 Re: size of attributes table is too big
Previous Message Lukas Fittl 2025-03-25 06:09:06 Re: query_id: jumble names of temp tables for better pg_stat_statement UX

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2025-03-25 07:04:37 Re: Add semi-join pushdown to postgres_fdw
Previous Message Jeff Davis 2025-03-25 06:53:33 Re: Statistics Import and Export