| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: vacuum_truncate configuration parameter and isset_offset |
| Date: | 2025-03-24 16:41:27 |
| Message-ID: | Z-GLN06DlD8p737q@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 24, 2025 at 05:00:51PM +0100, Álvaro Herrera wrote:
> I don't understand why this shouldn't work exactly like
> vacuum_index_cleanup (cf. vacuum_rel lines 2170ff). That would require
> no new mechanism.
I explained my reasons for not proceeding with that approach upthread [0].
I don't think there are any existing reloptions where there are two ways to
say "use the GUC." For ones with corresponding GUCs, unsetting the storage
parameter is the mechanism for doing so. vacuum_index_cleanup's AUTO
option would be the closest thing, but there's no backing GUC, so the
meaning of AUTO doesn't change unless someone changes the code.
TBH I'm not understanding the pushback for adding a way to determine
whether the storage parameter is actually set. It's very simple, and it
seems like it could be useful elsewhere. But more importantly, it allows
us to more closely match the behavior of the existing reloptions with GUCs,
and it prevents type mismatches (e.g., the reloption is an enum but the GUC
is a Boolean).
[0] https://postgr.es/m/Z-Fvmnf57z6zM8Ky%40nathan
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Shaplov | 2025-03-24 16:53:43 | Re: vacuum_truncate configuration parameter and isset_offset |
| Previous Message | David G. Johnston | 2025-03-24 16:40:24 | Re: vacuum_truncate configuration parameter and isset_offset |