Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Date: 2022-10-04 06:28:53
Message-ID: YzvSpcONIe3gjrVp@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 04, 2022 at 03:17:06PM +0900, Kyotaro Horiguchi wrote:
> Nice finding. I found a few '%08X%08X's but they don't seem to fit
> similar fix.

Nice cleanup.

> Couldn't we use XLByteToSeg() here?
>
> Other than that, it looks good to me.

Yep. It looks that you're right here.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-10-04 06:30:32 Re: Convert macros to static inline functions
Previous Message Kyotaro Horiguchi 2022-10-04 06:23:48 Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file