Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: bharath(dot)rupireddyforpostgres(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Date: 2022-10-04 06:23:48
Message-ID: 20221004.152348.905742618983525147.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 04 Oct 2022 15:17:06 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> Other than that, it looks good to me.

Sorry I have another comment.

> - unsigned int tli,
> - log,
> - seg;
> + unsigned int tli;
> XLogSegNo segno;

TLI should be of type TimeLineID.

This is not directly related to this patch, pg_resetwal.c has the
following line..

> static uint32 minXlogTli = 0;

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-10-04 06:28:53 Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Previous Message Bharath Rupireddy 2022-10-04 06:22:23 Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file