| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, pryzby(at)telsasoft(dot)com, AndrewBille(at)gmail(dot)com |
| Subject: | Re: ICU for global collation |
| Date: | 2022-08-24 04:38:44 |
| Message-ID: | YwWrVEDpLNGFA4Mq@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 23, 2022 at 08:59:02PM +0300, Marina Polyakova wrote:
> My colleague Andrew Bille found another bug in master
> (b4e936859dc441102eb0b6fb7a104f3948c90490) and REL_15_STABLE
> (2c63b0930aee1bb5c265fad4a65c9d0b62b1f9da): pg_collation.colliculocale is
> not dumped. See check_icu_locale.sh:
>
> In the old cluster:
> SELECT collname, colliculocale FROM pg_collation WHERE collname =
> 'testcoll_backwards'
> collname | colliculocale
> --------------------+-------------------
> testcoll_backwards | @colBackwards=yes
> (1 row)
>
> In the new cluster:
> SELECT collname, colliculocale FROM pg_collation WHERE collname =
> 'testcoll_backwards'
> collname | colliculocale
> --------------------+---------------
> testcoll_backwards |
> (1 row)
>
> diff_dump_colliculocale.patch works for me.
Ugh. Good catch, again! I have not tested the patch in details but
this looks rather sane to me on a quick read. Peter?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-24 04:40:54 | Re: [PATCH] Expose port->authn_id to extensions and triggers |
| Previous Message | Michael Paquier | 2022-08-24 04:34:54 | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |