| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, pryzby(at)telsasoft(dot)com, AndrewBille(at)gmail(dot)com |
| Subject: | Re: ICU for global collation |
| Date: | 2022-08-24 08:59:23 |
| Message-ID: | 20220824085923.jro5ao2m5b4mdll5@jrouhaud |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 24, 2022 at 01:38:44PM +0900, Michael Paquier wrote:
> On Tue, Aug 23, 2022 at 08:59:02PM +0300, Marina Polyakova wrote:
> > My colleague Andrew Bille found another bug in master
> > (b4e936859dc441102eb0b6fb7a104f3948c90490) and REL_15_STABLE
> > (2c63b0930aee1bb5c265fad4a65c9d0b62b1f9da): pg_collation.colliculocale is
> > not dumped. See check_icu_locale.sh:
> >
> > In the old cluster:
> > SELECT collname, colliculocale FROM pg_collation WHERE collname =
> > 'testcoll_backwards'
> > collname | colliculocale
> > --------------------+-------------------
> > testcoll_backwards | @colBackwards=yes
> > (1 row)
> >
> > In the new cluster:
> > SELECT collname, colliculocale FROM pg_collation WHERE collname =
> > 'testcoll_backwards'
> > collname | colliculocale
> > --------------------+---------------
> > testcoll_backwards |
> > (1 row)
> >
> > diff_dump_colliculocale.patch works for me.
>
> Ugh. Good catch, again!
+1
> I have not tested the patch in details but
> this looks rather sane to me on a quick read. Peter?
Patch looks good to me too.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-08-24 09:06:13 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Previous Message | Kyotaro Horiguchi | 2022-08-24 08:40:07 | Re: standby promotion can create unreadable WAL |