Re: pg_basebackup: add test about zstd compress option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dong Wook Lee <sh95119(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_basebackup: add test about zstd compress option
Date: 2022-08-23 02:36:57
Message-ID: YwQ9SWlS2bcUymMC@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 23, 2022 at 10:58:22AM +0900, Dong Wook Lee wrote:
> I checked the test code not to test the zstd option, then added it.
> I hope my patch will help us to ensure safety of the test.

It seems to me that checking that the contents generated are valid is
equally necessary. We do that with zlib with gzip --test, and you
could use ${ZSTD} in the context of this test.

What about lz4?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-08-23 02:38:42 Re: standby promotion can create unreadable WAL
Previous Message Amit Langote 2022-08-23 02:35:11 Re: SQL/JSON features for v15