From: | Dong Wook Lee <sh95119(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_basebackup: add test about zstd compress option |
Date: | 2022-08-25 07:52:04 |
Message-ID: | CAAcBya+MHX+ST0F2YmsqPjNPhN_JeWp54Q2-6oq_AtEDq3n46w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 23, 2022 at 11:37 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> It seems to me that checking that the contents generated are valid is
> equally necessary. We do that with zlib with gzip --test, and you
> could use ${ZSTD} in the context of this test.
Thank you for the good points.
I supplemented the test according to your suggestion.
However, there was a problem.
Even though I did export ZSTD on the Makefile , the test runner can't
find ZSTD when it actually tests.
```
my $zstd = $ENV{ZSTD};
skip "program zstd is not found in your system", 1
if (!defined $zstd
|| $zstd eq '');
```
log: regress_log_010_pg_basebackup
```
ok 183 # skip program zstd is not found in your system.
```
Could you check if I missed anything?
Attachment | Content-Type | Size |
---|---|---|
v2_add_test_pg_basebackup.patch | application/octet-stream | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2022-08-25 08:25:49 | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
Previous Message | Kyotaro Horiguchi | 2022-08-25 07:49:17 | Re: pg_rewind WAL segments deletion pitfall |