| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Backup command and functions can cause assertion failure and segmentation fault |
| Date: | 2022-07-20 06:49:17 |
| Message-ID: | YtelbUzJt1Nsa27T@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 20, 2022 at 02:00:00PM +0900, Fujii Masao wrote:
> I reported two trouble cases; they are the cases where BASE_BACKUP
> is canceled and terminated, respectively. But you added the test
> only for one of them. Is this intentional?
Nope. The one I have implemented was the fanciest case among the
two, so I just focused on it.
Adding an extra test to cover the second scenario is easier. So I
have added one as of the attached, addressing your other comments
while on it. I have also decided to add the tests at the bottom of
001_stream_rep.pl, as these are quicker than a node initialization.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-more-TAP-tests-with-BASE_BACKUP.patch | text/x-diff | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tushar | 2022-07-20 07:01:29 | Re: replacing role-level NOINHERIT with a grant-level option |
| Previous Message | Kyotaro Horiguchi | 2022-07-20 06:28:36 | Re: Allow placeholders in ALTER ROLE w/o superuser |