Re: Memory leak fix in psql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Memory leak fix in psql
Date: 2022-07-20 03:51:32
Message-ID: Ytd7xIiR3QvnBYST@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 20, 2022 at 03:14:35AM +0000, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
> Your fix LGTM so please allow me to merge it in the attached patch.
> Based on your rebased version, now this new patch version is V3.

What about the argument of upthread where we could use a goto in
functions where there are multiple pattern validation checks? Per se
v4 attached.
--
Michael

Attachment Content-Type Size
v4-0001-fix-the-memory-leak-in-psql-describe.patch text/x-diff 18.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-07-20 03:56:53 Re: Is select_outer_pathkeys_for_merge() too strict now we have Incremental Sorts?
Previous Message Masahiko Sawada 2022-07-20 03:30:24 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns