| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Memory leak fix in psql |
| Date: | 2022-07-20 06:21:36 |
| Message-ID: | OS0PR01MB6113A19CCF1DA7A988DA492FFB8E9@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, July 20, 2022 12:52 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> What about the argument of upthread where we could use a goto in
> functions where there are multiple pattern validation checks? Per se
> v4 attached.
Thanks for your kindly remind and modification.
I checked v4 patch, it looks good but I think there can be some minor improvement.
So I deleted some redundant braces around "goto error_return; ".
Also added an error handle section in validateSQLNamePattern.
Kindly to have a check at the attached v5 patch.
Regards,
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-fix-the-memory-leak-in-psql-describe.patch | application/octet-stream | 18.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-07-20 06:28:36 | Re: Allow placeholders in ALTER ROLE w/o superuser |
| Previous Message | Masahiko Sawada | 2022-07-20 06:12:13 | Re: Transparent column encryption |