Re: PATCH: Add Table Access Method option to pgbench

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Mason Sharp <masonlists(at)gmail(dot)com>, Michel Pelletier <michel(at)supabase(dot)io>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PATCH: Add Table Access Method option to pgbench
Date: 2022-07-19 01:47:44
Message-ID: YtYNQJOKoA4YqXYb@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 18, 2022 at 01:53:21PM +0300, Alexander Korotkov wrote:
> Looks good to me as well. I'm going to push this if no objections.

FWIW, I find the extra mention of PGOPTIONS with the specific point of
table AMs added within the part of the environment variables a bit
confusing, because we already mention PGOPTIONS for serializable
transactions a bit down. Hence, my choice would be the addition of an
extra paragraph in the "Notes", named "Table Access Methods", just
before or after "Good Practices". My 2c.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-07-19 02:10:42 Re: [PoC] Improve dead tuple storage for lazy vacuum
Previous Message John Naylor 2022-07-19 01:30:48 Re: NAMEDATALEN increase because of non-latin languages