| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Mason Sharp <masonlists(at)gmail(dot)com>, Michel Pelletier <michel(at)supabase(dot)io>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PATCH: Add Table Access Method option to pgbench |
| Date: | 2022-07-20 12:51:55 |
| Message-ID: | CAPpHfdvsudAu8mecTSY2vcjK1GSzPfHKQ=hhPSnbV0WgbBjBbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Tue, Jul 19, 2022 at 4:47 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Jul 18, 2022 at 01:53:21PM +0300, Alexander Korotkov wrote:
> > Looks good to me as well. I'm going to push this if no objections.
>
> FWIW, I find the extra mention of PGOPTIONS with the specific point of
> table AMs added within the part of the environment variables a bit
> confusing, because we already mention PGOPTIONS for serializable
> transactions a bit down. Hence, my choice would be the addition of an
> extra paragraph in the "Notes", named "Table Access Methods", just
> before or after "Good Practices". My 2c.
Thank you. Pushed applying the suggestion above.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-20 13:34:37 | Re: Remove fls(), use pg_bitutils.h facilities instead? |
| Previous Message | houzj.fnst@fujitsu.com | 2022-07-20 12:28:26 | RE: Support logical replication of DDLs |