From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Remove support for Visual Studio 2013 |
Date: | 2022-05-30 07:48:22 |
Message-ID: | YpR2xhVegjXYMvpH@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 26, 2022 at 05:50:40PM -0400, Tom Lane wrote:
> The comments about that in win32_port.h and cygwin.h only date back
> to 2019, so it seems unlikely that the situation has changed much.
> We could try removing HAVE_BUGGY_STRTOF to see if the buildfarm
> complains, but I wouldn't bet money on that succeeding. What we
> *do* need to do is update the #if tests and comments to make clear
> that HAVE_BUGGY_STRTOF is only needed for Mingw and Cygwin, not
> for any supported MSVC release.
After looking at that again, the whole comment related to VS in
strtof.c can be removed. I have noticed while on it more places that
still referred to VS2013 in ./configure[.ac] and win32_langinfo() got
an overall incorrect description. This leads to v2 as of the
attached.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Remove-support-for-VS-2013.patch | text/x-diff | 18.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-05-30 08:08:10 | Re: Remove useless tests about TRUNCATE on foreign table |
Previous Message | Pavan Deolasee | 2022-05-30 07:07:51 | Re: Shmem queue is not flushed if receiver is not yet attached |