From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Estimating HugePages Requirements? |
Date: | 2022-04-26 01:34:06 |
Message-ID: | YmdMDiCCyVJLlB/F@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-admin pgsql-hackers |
On Mon, Apr 25, 2022 at 04:55:25PM +0200, Magnus Hagander wrote:
> AIUI that was the original use-case for this feature. It certainly was for
> me :)
Perhaps we'd be fine with relaxing the requirements here knowing that
the control file should never be larger than PG_CONTROL_MAX_SAFE_SIZE
(aka the read should be atomic so it could be made lockless). At the
end of the day, to be absolutely correct in the shmem size estimation,
I think that we are going to need what's proposed here or the sizing
may not be right depending on how extensions adjust GUCs after they
load their _PG_init():
https://www.postgresql.org/message-id/20220419154658.GA2487941@nathanxps13
That's a bit independent, but not completely unrelated either
depending on how exact you want your number of estimated huge pages to
be. Just wanted to mention it.
>> Contrary to Linux, we don't need to care about the number of large
>> pages that are necessary because there is no equivalent of
>> vm.nr_hugepages on Windows (see [1]), do we? If that were the case,
>> we'd have a use case for huge_page_size, additionally.
>
> Right, for this one in particular -- that's what I meant with my comment
> about there not being a limit. But this feature works for other settings as
> well, not just the huge pages one. Exactly what the use-cases are can
> vary, but surely they would have the same problems wrt redirects?
Yes, the redirection issue would apply to all the run-time GUCs.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Wells Oliver | 2022-04-26 17:08:31 | CTEs and temp_buffers? |
Previous Message | Magnus Hagander | 2022-04-25 14:55:25 | Re: Estimating HugePages Requirements? |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2022-04-26 01:55:21 | Re: Skipping schema changes in publication |
Previous Message | Michael Paquier | 2022-04-26 01:01:20 | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |