Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

On Mon, Apr 25, 2022 at 01:34:38PM -0700, Nathan Bossart wrote:
> I took another look at the example output, and I think I agree that logging
> the total time for logical decoding operations is probably the best path
> forward. This information would be enough to clue an administrator into
> the possible causes of lengthy checkpoints, but it also wouldn't disrupt
> the readability of the log statement too much.

+ /* translator: the placeholders after first %s show restartpoint/checkpoint options */
+ (errmsg("%s starting:%s%s%s%s%s%s%s%s",
+ restartpoint ?
_("restartpoint") : _("checkpoint"),

0001 breaks translation, as "checkpoint/restartpoint" and "starting"
would treated as separate terms to translate. That would not matter
for English, but it does in French where we'd say "début du
checkpoint". You could fix that by adding "starting" to each
refactored term or build a string. 0002 does the latter, so my take
is that you should begin using a StringInfo in 0001.
--
Michael