From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | thomas(dot)munro(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pg_tablespace_location() failure with allow_in_place_tablespaces |
Date: | 2022-03-17 02:52:56 |
Message-ID: | YjKiiPX+zdtU7Go1@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 16, 2022 at 05:15:58PM +0900, Kyotaro Horiguchi wrote:
> I'm not sure that the "of the symbolic link in pg_tblspc/" is
> needed. And allow_in_place_tablespaces alone doesn't create in-place
> tablespace. So this might need rethink at least for the second point.
Surely this can be improved. I was not satisfied with this paragraph
after re-reading it this morning, so I have just removed it, rewording
slightly the part for in-place tablespaces that is still necessary.
> Agreed. And v2 looks cleaner.
>
> The test detects the lack of the feature.
> It successfully builds and runs on Rocky8 and Windows11.
Thanks for the review. After a second look, it seemed fine so I have
applied it. (I'll try to jump on the tablespace patch for recovery
soon-ish-ly if nobody beats me to it.)
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2022-03-17 03:02:48 | Re: BufferAlloc: don't take two simultaneous locks |
Previous Message | shiy.fnst@fujitsu.com | 2022-03-17 02:43:31 | RE: Skipping logical replication transactions on subscriber side |