Re: pg_upgrade should truncate/remove its logs before running

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: 2022-01-20 10:51:37
Message-ID: Yek+uQp/kMn2O3aK@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 20, 2022 at 10:31:15AM +0100, Peter Eisentraut wrote:
> I'm afraid that is too easily confused with the target directory. Generally,
> a tool processes data from input to output or from source to target or
> something like that, whereas a log is more clearly something separate from
> this main processing stream. The desired "output" of pg_upgrade is the
> upgraded cluster, after all.
>
> A wildcard idea is to put the log output into the target cluster.

Neat idea. That would work fine for my case. So I am fine to stick
with this suggestion.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-01-20 11:24:46 Re: row filtering for logical replication
Previous Message Michael Paquier 2022-01-20 10:50:31 Re: Null commitTS bug