Re: pg_upgrade should truncate/remove its logs before running

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: 2022-01-20 09:31:15
Message-ID: 45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.01.22 09:13, Michael Paquier wrote:
> - Renaming of the option from --logdir to --outputdir, as this does
> not include only logs. That matches also better with default value
> assigned in previous patches, aka pg_upgrade_output.d.

I'm afraid that is too easily confused with the target directory.
Generally, a tool processes data from input to output or from source to
target or something like that, whereas a log is more clearly something
separate from this main processing stream. The desired "output" of
pg_upgrade is the upgraded cluster, after all.

A wildcard idea is to put the log output into the target cluster.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Wenjing Zeng 2022-01-20 09:53:05 Re: [Proposal] Global temporary tables
Previous Message wangw.fnst@fujitsu.com 2022-01-20 09:05:09 RE: Logical replication timeout problem