Re: An obsolete comment of pg_stat_statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: rjuju123(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: An obsolete comment of pg_stat_statements
Date: 2022-01-03 08:36:25
Message-ID: YdK1ic8Pzjs2SxiU@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 24, 2021 at 09:02:10PM +0900, Michael Paquier wrote:
> Do we really need to have this comment in the function header? The
> same is explained a couple of lines down so this feels like a
> duplicate, and it is hard to miss it with the code shaped as-is (aka
> the relationship between compute_query_id and queryId and the
> consequences on what's stored in this case).

The simpler the better here. So, I have just removed this comment
after thinking more about this.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-01-03 11:04:52 Re: Add Boolean node
Previous Message Michael Paquier 2022-01-03 08:17:20 Re: Remove inconsistent quotes from date_part error