Re: An obsolete comment of pg_stat_statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: rjuju123(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: An obsolete comment of pg_stat_statements
Date: 2021-12-24 12:02:10
Message-ID: YcW2wlaKjrsEtfRj@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 24, 2021 at 03:32:10PM +0900, Kyotaro Horiguchi wrote:
> Thanks! Looks better. It is used as-is in the attached.
>
> And I will register this to the next CF.

Do we really need to have this comment in the function header? The
same is explained a couple of lines down so this feels like a
duplicate, and it is hard to miss it with the code shaped as-is (aka
the relationship between compute_query_id and queryId and the
consequences on what's stored in this case).
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-12-24 12:07:51 Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Previous Message Bharath Rupireddy 2021-12-24 12:01:37 Re: Throttling WAL inserts when the standby falls behind more than the configured replica_lag_in_bytes