From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: pgsql: Add TAP tests for contrib/sslinfo |
Date: | 2021-12-01 06:19:10 |
Message-ID: | YacT3tm97xziSUFw@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Tue, Nov 30, 2021 at 11:34:21PM -0500, Tom Lane wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> > Oh, interesting, I hadn't realized that. I'll go do that instead then.
>
> ... okay, so all we learned is that it really is an ENOENT failure.
>
> At this point my guess is that the test is copying the key file
> to the wrong place because of an MSys path issue. I don't know
> that topic well enough to debug it, though.
Daniel has pinged me about this issue. From what I can see, c113d8ad
has changed 001_ssltests.pl so as the keys are not anymore relative
paths with *_tmp* names but absolute paths with the same key name, so
it seems to me that you should sprinkle some perl2host() calls in the
${PostgreSQL::Test::Utils::tmp_check} paths to allow Msys to
understand them. At quick glance, it looks like this is the first
time we'd pass down absolute paths to libpq within connection
strings in the TAP tests.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-12-01 07:34:37 | pgsql: Fix regression test failure caused by commit 8d74fc96db. |
Previous Message | Amit Kapila | 2021-12-01 05:06:00 | pgsql: Doc: Add "Attach Partition" limitation during logical replicatio |