pgsql: Fix regression test failure caused by commit 8d74fc96db.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix regression test failure caused by commit 8d74fc96db.
Date: 2021-12-01 07:34:37
Message-ID: E1msK8T-0003lM-TS@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix regression test failure caused by commit 8d74fc96db.

The tests didn't considered that an error unrelated to apply changes, e.g.
"replication origin with OID %d is already active ...", could occur on the
table sync worker before starting to copy changes.

To make the test robust we instead need to check the expected error and
the source of error which will be either tablesync or apply worker.

In passing remove the harmless option "streaming = off" from Create
Subscription command as that is anyway the default.

Per buildfarm member sidewinder.

Author: Masahiko Sawada
Reviewed-by: Hou Zhijie, Vignesh C, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoDeScrsHhLyEPYqN3sydg6PxAPVBboK=30xJfUVihNZDA@mail.gmail.com
Discussion: https://postgr.es/m/E1mrtvV-0002Gz-73@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/41e66fee051619ab84828814554f73556a958850

Modified Files
--------------
src/test/subscription/t/026_worker_stats.pl | 59 +++++++++++++++++------------
1 file changed, 34 insertions(+), 25 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-12-01 10:27:45 pgsql: doc: Some additional information about when to use referential a
Previous Message Michael Paquier 2021-12-01 06:19:10 Re: pgsql: Add TAP tests for contrib/sslinfo