| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, amul sul <sulamul(at)gmail(dot)com> |
| Subject: | Re: RecoveryInProgress() has critical side effects |
| Date: | 2021-11-16 02:34:40 |
| Message-ID: | YZMYwDrseKTtZ9EB@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 15, 2021 at 10:09:17PM +0000, Bossart, Nathan wrote:
> On 11/15/21, 1:30 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
>> Here's a new version that does it that way. Any other opinions?
>
> LGTM
Patch 0001 means that the startup process would set up the structures
to be able to build WAL records before running any kind of recovery
action rather than doing it when it really needs it. That's fine by
me.
Is patch 0002 actually right regarding the handling of doPageWrites?
Once applied, we finish by setting it when the startup process starts
and not anymore at the end of recovery based on its the state of
Insert, but this could have changed while in recovery when replaying
one or more XLOG_FPW_CHANGE records.
> I'm personally not too worried about a ~4% regression in this
> particular benchmark...
This is not a hot code path, that should be fine.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-11-16 02:38:03 | Re: support for MERGE |
| Previous Message | Bharath Rupireddy | 2021-11-16 02:34:23 | Re: Printing backtrace of postgres processes |