| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, amul sul <sulamul(at)gmail(dot)com> |
| Subject: | Re: RecoveryInProgress() has critical side effects |
| Date: | 2021-11-15 22:09:17 |
| Message-ID: | FE730879-BCD5-44E8-9FD6-7DAA5E06C948@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/15/21, 1:30 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
> Here's a new version that does it that way. Any other opinions?
LGTM
> The best thing I could come up with for a test case for this was to
> try repeatedly making a new connection and running "SELECT
> txid_current()", which will cause just one WAL record to be generated.
> Unfortunately that path has overhead from a lot of other causes so I'm
> not sure the results are very meaningful, but here they are:
>
> v1: 0.378 ms
> v2: 0.391 ms
> common base commit (10eae82b2): 0.376 ms
I'm personally not too worried about a ~4% regression in this
particular benchmark...
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2021-11-15 22:23:48 | Re: [PATCH v2] use has_privs_for_role for predefined roles |
| Previous Message | Thomas Munro | 2021-11-15 22:08:15 | Re: [RFC] building postgres with meson |