Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: a(dot)kozhemyakin(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru
Date: 2021-11-11 08:08:34
Message-ID: YYzPgnGBCi75zOWy@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Nov 11, 2021 at 12:19:09PM +0900, Kyotaro Horiguchi wrote:
> I'm not sure which is easier to read, but it might be a bit hard since
> the conditino term in not mention counter itself. I don't object to
> that way. And, yes SLRU_NUM_ELEMENTS cannot be used here:p
>
> The attached is the first way in the choices.

That looks fine.

Also, what do you think about adding a test in sysviews.sql? This
could be as simple as that:
SELECT count(*) > 0 AS ok FROM pg_stat_slru;

I am not sure if the buildfarm animals running valgrind would have
caught this issue, but having something would be better than nothing
for this case.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2021-11-11 09:08:41 BUG #17281: How specify regress database?
Previous Message Peter Geoghegan 2021-11-11 03:33:01 Re: BUG #17255: Server crashes in index_delete_sort_cmp() due to race condition with vacuum