| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sven Klemm <sven(at)timescale(dot)com> |
| Subject: | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Date: | 2021-10-21 03:27:03 |
| Message-ID: | YXDeB+wASDrzluwA@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 20, 2021 at 07:59:50PM -0700, Peter Geoghegan wrote:
> I think that EDB's pg_catcheck tool can detect problems like this one.
Yes, pg_catcheck is able to catch that.
> Perhaps it can be converted into an amcheck/pg_amcheck patch, and
> submitted. That would give us very broad coverage.
Perhaps. This means the creation of a new database with shared deps
in contrib/amcheck/t/. But is amcheck really a correct target here?
The fields involved here are an int, some OIDs and a char with a given
subset of values making them harder to check. pg_catcheck does checks
across catalogs, maintaining a mapping list as of its definitions.c.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-10-21 03:35:41 | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Previous Message | Dilip Kumar | 2021-10-21 03:10:12 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |