| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sven Klemm <sven(at)timescale(dot)com> |
| Subject: | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Date: | 2021-10-21 03:35:41 |
| Message-ID: | CAH2-WznneOHnZZZVd1+OWc_+DRaFefjum_0fqLvScG+aB=Hk0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 20, 2021 at 8:27 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Perhaps. This means the creation of a new database with shared deps
> in contrib/amcheck/t/. But is amcheck really a correct target here?
> The fields involved here are an int, some OIDs and a char with a given
> subset of values making them harder to check. pg_catcheck does checks
> across catalogs, maintaining a mapping list as of its definitions.c.
Users should be able to use pg_amcheck as a high-level corruption
detection tool, which should include any new pg_catcheck style catalog
checking functionality. Whether or not we need to involve
contrib/amcheck itself doesn't seem important to me right now. Offhand
I think that we wouldn't, because as you point out pg_catcheck is a
frontend program that checks multiple databases.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-10-21 03:40:55 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Previous Message | Michael Paquier | 2021-10-21 03:27:03 | Re: [PATCH] Fix memory corruption in pg_shdepend.c |