Re: [PATCH] Tab completion for ALTER TABLE … ADD …

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Tab completion for ALTER TABLE … ADD …
Date: 2021-08-27 04:04:00
Message-ID: YShkMBE3sq8mDa1S@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 03, 2021 at 12:48:38PM +0100, Dagfinn Ilmari Mannsåker wrote:
> The other day I noticed that there's no tab completion after ALTER TABLE
> … ADD, so here's a patch. In addition to COLUMN and all the table
> constraint types, it also completes with the list of unique indexes on
> the table after ALTER TABLE … ADD … USING INDEX.

I was reading this patch (not actually tested), and that's a clear
improvement. One extra thing that could be done here is to complete
with types for a ALTER TABLE ADD COLUMN foo. We could as well have a
list of columns after UNIQUE or PRIMARY KEY, but that feels like extra
cream on top of the cake. In short I am fine with what you have
here.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-08-27 04:32:26 Re: Error code for checksum failure in origin.c
Previous Message Michael Paquier 2021-08-27 03:44:32 Re: pg_receivewal starting position