Re: pgsql: Move temporary file cleanup to before_shmem_exit().

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move temporary file cleanup to before_shmem_exit().
Date: 2021-08-10 07:05:25
Message-ID: YRIlNQhLNfx555Nx@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Aug 08, 2021 at 02:23:06AM +0000, Andres Freund wrote:
> Move temporary file cleanup to before_shmem_exit().
>
> As reported by a few OSX buildfarm animals there exist at least one path where
> temporary files exist during AtProcExit_Files() processing. As temporary file
> cleanup causes pgstat reporting, the assertions added in ee3f8d3d3ae caused
> failures.

While going through the latest updates, I have noticed a typo:

+ * Initialize temporary file access after pgstat, so that the temorary
+ * file shutdown hook can report temporary file statistics.
With one s/temorary/temporary/ here.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-08-10 09:31:03 pgsql: Remove unused regression test certificate server-ss
Previous Message Michael Paquier 2021-08-10 07:03:13 pgsql: Add tab completion for DECLARE .. ASENSITIVE in psql