| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Move temporary file cleanup to before_shmem_exit(). |
| Date: | 2021-08-13 12:47:13 |
| Message-ID: | 20210813124713.sc4lyr3nr3334g7p@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2021-08-10 16:05:25 +0900, Michael Paquier wrote:
> On Sun, Aug 08, 2021 at 02:23:06AM +0000, Andres Freund wrote:
> > Move temporary file cleanup to before_shmem_exit().
> >
> > As reported by a few OSX buildfarm animals there exist at least one path where
> > temporary files exist during AtProcExit_Files() processing. As temporary file
> > cleanup causes pgstat reporting, the assertions added in ee3f8d3d3ae caused
> > failures.
>
> While going through the latest updates, I have noticed a typo:
>
> + * Initialize temporary file access after pgstat, so that the temorary
> + * file shutdown hook can report temporary file statistics.
> With one s/temorary/temporary/ here.
Thanks, fixed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-08-13 12:53:10 | pgsql: Remove support for background workers without BGWORKER_SHMEM_ACC |
| Previous Message | Andres Freund | 2021-08-13 12:47:09 | pgsql: Fix typo. |