| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Some code cleanup for pgbench and pg_verifybackup |
| Date: | 2021-07-29 07:16:59 |
| Message-ID: | YQJV6x4XbEluEuzQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 28, 2021 at 10:28:13AM -0400, Robert Haas wrote:
> I think all of these are reasonable fixes. In the case of
> pg_basebackup, a chmod() failure doesn't necessarily oblige us to give
> up and exit; we could presumably still write the data. But it may be
> best to give up and exit. The other cases appear to be clear bugs.
Yeah, there are advantages in both positions, still it is more natural
to me to not ignore this kind of failures. Note the inconsistency
with initdb for example. So, done.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-07-29 07:59:21 | Re: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep |
| Previous Message | Peter Smith | 2021-07-29 07:01:52 | Re: Out-of-memory error reports in libpq |