Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: 2021-07-13 01:56:42
Message-ID: YOzy2rlluWYYoUvW@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 12, 2021 at 07:46:32PM -0400, Tom Lane wrote:
> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
> as 1 or 0, but some of the entries in msvc/Solution.pm show
> such symbols as "undef" instead. Shouldn't we fix it as
> per attached? This is probably only cosmetic at the moment,
> but it could bite us someday if someone wrote a complex
> conditional using one of these symbols.

Hmm. I have not tested, but agreed that this is inconsistent. I
would tend to vote for a backpatch to keep some consistency across the
branches as changes in this area could easily lead to rather conflicts
harder to parse.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-07-13 02:00:49 Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Previous Message Andres Freund 2021-07-13 01:56:09 Re: O_DIRECT on macOS