Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Date: 2021-07-13 02:00:49
Message-ID: CAApHDvr=eKFBzuL5e_0DBpN5sUuNE-dGq+vZ-t=K+6MCZatCXg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 13 Jul 2021 at 06:50, Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> Your version looks better to me than the original version, but I'm still
> -0.05 on changing this at all.

I was more +0.4. It does not seem worth the trouble of too much
discussion so, just to try and bring this to a close, instead of
adding a comment to explain why we needlessly check the range of the
INT8 sequence, I just pushed the patch that removes it and adds the 1
line comment to mention why it's not needed.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2021-07-13 02:22:14 Re: Synchronous commit behavior during network outage
Previous Message Michael Paquier 2021-07-13 01:56:42 Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm