Re: [PATCH] Pull general SASL framework out of SCRAM

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
Date: 2021-07-13 00:47:15
Message-ID: YOzik3o+ps3XIlGZ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 13, 2021 at 12:01:46AM +0000, Jacob Champion wrote:
> Ah, right. I think the (!done && !success) case is probably indicative
> of an API smell, but that's probably something to clean up in a future
> pass.

Yeah, agreed. I feel that it would should be cleaner to replace those
two booleans with a status enum or a bitmask.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-07-13 01:05:08 Re: Small documentation improvement for ALTER SUBSCRIPTION
Previous Message Michael Paquier 2021-07-13 00:28:30 Re: Incorrect usage of strtol, atoi for non-numeric junk inputs