| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Adrian Ho <ml+postgresql(at)03s(dot)net>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x |
| Date: | 2021-07-08 08:04:54 |
| Message-ID: | YOaxpoHOiO7Q41F2@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Jul 08, 2021 at 09:53:11AM +0200, Daniel Gustafsson wrote:
> Couldn't we add a version check to find if we have < 2.5 or >= 2.5, and adjust
> libs accordingly? Alternatively we could perhaps check for
> LDAP_API_FEATURE_X_OPENLDAP_REENTRANT which IIUC when set defines -lldap to be
> reentrant.
Would you fetch the version number directly from the library? I'd
like to think that it could be more simple to rely on an object
defined in the library instead as that's what we do for OpenSSL. Now
OpenLDAP has not a history with forks as complicated as OpenSSL,
making a version number something more reliable?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Lepikhov | 2021-07-08 08:06:46 | Re: The case when AsyncAppend exists also in the qual of Async ForeignScan |
| Previous Message | Daniel Gustafsson | 2021-07-08 07:53:11 | Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x |