Re: Introduce pg_receivewal gzip compression tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: gkokolatos(at)pm(dot)me
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce pg_receivewal gzip compression tests
Date: 2021-07-15 07:00:17
Message-ID: YO/coGVNAZTARxEw@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 14, 2021 at 02:11:09PM +0000, gkokolatos(at)pm(dot)me wrote:
> Please find v6 attached.

Thanks. I have spent some time checking this stuff in details, and
I did some tests on Windows while on it. A run of pgperltidy was
missing. A second thing is that you added one useless WAL segment
switch in the ZLIB block, and two at the end, causing the first two in
the set of three (one in the ZLIB block and one in the final command)
to be no-ops as they followed a previous WAL switch. The final one
was not needed as no WAL is generated after that.

And applied. Let's see if the buildfarm has anything to say. Perhaps
this will even catch some bugs that pre-existed.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-07-15 07:02:48 Re: Remove redundant Assert(PgArchPID == 0); in PostmasterStateMachine
Previous Message Simon Riggs 2021-07-15 07:00:08 Re: VACUUM (DISABLE_PAGE_SKIPPING on)