From: | gkokolatos(at)pm(dot)me |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Introduce pg_receivewal gzip compression tests |
Date: | 2021-07-15 07:48:08 |
Message-ID: | UEfDrva3Z-7dBiFYyj9Di0C-Ms1E2rbBCfgmgeP--2knm3ij4KddMN56vmtRlL_pp4CIYGhw_uaccoTjVBsTsk7xS4VHe-93TKg2tQb4JM0=@pm.me |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, July 15th, 2021 at 09:00, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jul 14, 2021 at 02:11:09PM +0000, gkokolatos(at)pm(dot)me wrote:
>
> > Please find v6 attached.
>
> Thanks. I have spent some time checking this stuff in details, and
> I did some tests on Windows while on it. A run of pgperltidy was
> missing. A second thing is that you added one useless WAL segment
> switch in the ZLIB block, and two at the end, causing the first two in
> the set of three (one in the ZLIB block and one in the final command)
> to be no-ops as they followed a previous WAL switch. The final one
> was not needed as no WAL is generated after that.
>
Thank you for the work and comments.
> And applied. Let's see if the buildfarm has anything to say. Perhaps
> this will even catch some bugs that pre-existed.
Let us hope that it will prevent some bugs from happening.
Cheers,
//Georgios
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2021-07-15 08:10:19 | Re: Enhanced error message to include hint messages for redundant options error |
Previous Message | Gilles Darold | 2021-07-15 07:44:13 | Re: [PATCH] Hooks at XactCommand level |