Re: Assertion on create index concurrently

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Assertion on create index concurrently
Date: 2021-06-27 01:35:49
Message-ID: YNfV9WfPh7eduCfM@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Jun 26, 2021 at 09:48:45PM +0300, Andrey Lepikhov wrote:
> I found one annoying assertion in the CREATE INDEX CONCURRENTLY operation.
> It will happen if you add into WHERE part of CREATE INDEX CONCURRENTLY some
> function that will make transactional update (see an example in the attached
> patch).
>
> It looks like a hack, but it lead to assertion and restart of the instance,
> that isn't good.
> I suggest to perform error, not assertion in this case (see the patch).
>
> This problem affects PG 9.6 - 13. The master branch was fixed 9 months ago
> by commit 83158f7, that made this operation transactional, but still.

This looks like a good argument for back-patching 83158f7 all the way
down, as 813fb03 exists since 9.4. Any thoughts from others?
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Sudheer H R 2021-06-27 14:02:06 Socket (fd) to posters server getting closed. (libpq)
Previous Message Alexander Korotkov 2021-06-26 23:29:06 Re: BUG #17066: Cache lookup failed when null (unknown) is passed as anycompatiblemultirange