Re: Fixup some appendStringInfo and appendPQExpBuffer calls

On Thu, Jun 03, 2021 at 01:53:34PM +1200, David Rowley wrote:
> I think it would be good to fix at least the instances that are new
> code in PG14 before we branch for PG15. They all seem low enough risk
> and worth keeping the new-to-PG14 code as close to the same as
> possible between major versions. It seems more likely that newer code
> will need bug fixes in the future so having the code as similar as
> possible in each branch makes backpatching easier.

> For the code that's not new to PG14, I feel less strongly about those.
> In the patch there's just 2 instances of these; one in
> contrib/sepgsql/schema.c and another in
> src/backend/postmaster/postmaster.c. I've tried to push for these
> sorts of things to be fixed at around this time of year in the past,
> but there have been other people thinking we should wait until we
> branch. For example [1] and [2].

No objections to those arguments, makes sense. I don't see an issue
with changing the new code before branching, FWIW. As you already did
110d817, perhaps you would prefer taking care of it?
--
Michael