| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fixup some appendStringInfo and appendPQExpBuffer calls |
| Date: | 2021-06-03 02:56:38 |
| Message-ID: | 243068.1622688998@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Wed, 2 Jun 2021 at 16:29, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Indeed, that's the same thing as 110d817 to make all those calls
>> cheaper. No objections from me to do those changes now rather than
>> later on HEAD.
> I think it would be good to fix at least the instances that are new
> code in PG14 before we branch for PG15. They all seem low enough risk
> and worth keeping the new-to-PG14 code as close to the same as
> possible between major versions.
+1 for fixing this sort of thing in new code before we branch.
I'm less interested in changing code that already exists in back
branches. I think the risk of causing headaches for back-patches
may outweigh any benefit of such micro-optimizations.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-03 03:00:56 | Re: Fixup some appendStringInfo and appendPQExpBuffer calls |
| Previous Message | Masahiko Sawada | 2021-06-03 02:56:19 | Re: Performance degradation of REFRESH MATERIALIZED VIEW |