Re: [PATCH] force_parallel_mode and GUC categories

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] force_parallel_mode and GUC categories
Date: 2021-04-13 07:34:23
Message-ID: YHVJfw2YN5/oGAcQ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

On Mon, Apr 12, 2021 at 01:40:52AM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> However, I'd like to think that we can do better than what's proposed
>> in the patch. There are a couple of things to consider here:
>> - Should the parameter be renamed to reflect that it should only be
>> used for testing purposes?
>
> -1 to that part, because it would break a bunch of buildfarm animals'
> configurations. I doubt that any gain in clarity would be worth it.

Okay.

>> - Should we make more general the description of the developer options
>> in the docs?
>
> Perhaps ... what did you have in mind?

The first sentence of the page now says that:
"The following parameters are intended for work on the PostgreSQL
source code, and in some cases to assist with recovery of severely
damaged databases."

That does not stick with force_parallel_mode IMO. Maybe:
"The following parameters are intended for development work related to
PostgreSQL. Some of them work on the PostgreSQL source code, some of
them can be used to control the run-time behavior of the server, and
in some cases they can be used to assist with the recovery of severely
damaged databases."
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Krzysztof Kois 2021-04-13 07:36:33 Unresolved repliaction hang and stop problem.
Previous Message Michael Paquier 2021-04-13 07:26:46 Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres

Browse pgsql-performance by date

  From Date Subject
Next Message Justin Pryzby 2021-04-13 12:31:39 Re: [PATCH] force_parallel_mode and GUC categories
Previous Message Nikolay Samokhvalov 2021-04-12 23:33:45 Re: LWLocks by LockManager slowing large DB